HyukjinKwon commented on code in PR #48451:
URL: https://github.com/apache/arrow/pull/48451#discussion_r2641561937
##########
python/pyarrow/tests/test_pandas.py:
##########
@@ -4114,24 +4114,40 @@ def test_dictionary_with_pandas():
d1 = pa.DictionaryArray.from_arrays(indices, dictionary)
d2 = pa.DictionaryArray.from_arrays(indices, dictionary, mask=mask)
- if index_type[0] == 'u':
- # TODO: unsigned dictionary indices to pandas
- with pytest.raises(TypeError):
+ if index_type == 'uint64':
+ # uint64 is not supported due to overflow risk (values > 2^63-1)
+ with pytest.raises(TypeError,
+ match="Converting unsigned dictionary indices"):
Review Comment:
Yup yup. let me fix it up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
