zanmato1984 commented on code in PR #48267: URL: https://github.com/apache/arrow/pull/48267#discussion_r2633432718
########## cpp/src/arrow/compute/function_internal.h: ########## @@ -352,6 +352,14 @@ static inline Result<std::shared_ptr<Scalar>> GenericToScalar( return MakeNullScalar(value); } +static inline Result<std::shared_ptr<Scalar>> GenericToScalar( Review Comment: Is this specialization necessary? I think we already have `std::optional<>` and `std::shared_ptr<DataType>` specialized, would them be enough for `std::optional<std::shared_ptr<DataType>`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
