tadeja commented on code in PR #48267:
URL: https://github.com/apache/arrow/pull/48267#discussion_r2636581142
##########
cpp/src/arrow/compute/function_internal.h:
##########
@@ -382,9 +382,10 @@ static inline Result<std::shared_ptr<Scalar>>
GenericToScalar(std::nullopt_t) {
}
template <typename T>
-static inline auto GenericToScalar(const std::optional<T>& value)
- -> Result<decltype(MakeScalar(value.value()))> {
- return value.has_value() ? MakeScalar(value.value()) :
std::make_shared<NullScalar>();
+static inline Result<std::shared_ptr<Scalar>> GenericToScalar(
+ const std::optional<T>& value) {
+ return value.has_value() ? GenericToScalar(value.value())
+ : std::make_shared<NullScalar>();
Review Comment:
The new change builds and passes CI now, however I can't evaluate it
critically enough. @zanmato1984 could you review this further?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
