tustvold commented on code in PR #583: URL: https://github.com/apache/arrow-rs-object-store/pull/583#discussion_r2637121863
########## src/lib.rs: ########## @@ -694,6 +694,33 @@ pub type MultipartId = String; /// /// To automatically detect this issue, use /// [`#[deny(clippy::missing_trait_methods)]`](https://rust-lang.github.io/rust-clippy/master/index.html#missing_trait_methods). +/// +/// # Upgrade Guide for 0.13.0 +/// +/// Upgrading to object_store 0.13.0 from an earlier version typically involves: +/// +/// 1. Add a `use` for [`ObjectStoreExt`] to solve the error +/// +/// ```text +/// error[E0599]: no method named `put` found for reference `&dyn object_store::ObjectStore` in the current scope +/// --> datafusion/datasource/src/url.rs:993:14 +/// ``` +/// +/// 2. Remove any (now) redundant implementations (such as `ObjectStore::put`) from any +/// `ObjectStore` implementations to resolve the error +/// +/// ```text +/// error[E0407]: method `put` is not a member of trait `ObjectStore` +/// --> datafusion/datasource/src/url.rs:1103:9 +/// | +/// ``` +/// +/// 3. Convert `ObjectStore::delete` to [`ObjectStore::delete_stream`] (see documentation Review Comment: Why do we direct users to delete_stream and copy_opts and not ObjectStoreExt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
