alamb commented on code in PR #583: URL: https://github.com/apache/arrow-rs-object-store/pull/583#discussion_r2637132577
########## src/lib.rs: ########## @@ -694,6 +694,33 @@ pub type MultipartId = String; /// /// To automatically detect this issue, use /// [`#[deny(clippy::missing_trait_methods)]`](https://rust-lang.github.io/rust-clippy/master/index.html#missing_trait_methods). +/// +/// # Upgrade Guide for 0.13.0 +/// +/// Upgrading to object_store 0.13.0 from an earlier version typically involves: +/// +/// 1. Add a `use` for [`ObjectStoreExt`] to solve the error +/// +/// ```text +/// error[E0599]: no method named `put` found for reference `&dyn object_store::ObjectStore` in the current scope +/// --> datafusion/datasource/src/url.rs:993:14 +/// ``` +/// +/// 2. Remove any (now) redundant implementations (such as `ObjectStore::put`) from any +/// `ObjectStore` implementations to resolve the error +/// +/// ```text +/// error[E0407]: method `put` is not a member of trait `ObjectStore` +/// --> datafusion/datasource/src/url.rs:1103:9 +/// | +/// ``` +/// +/// 3. Convert `ObjectStore::delete` to [`ObjectStore::delete_stream`] (see documentation Review Comment: This was meant for people who have implemented `ObjectStore` (not people who are calling) What has happened is they now need to implement `ObjectStore::delete_stream` The documentation on ObjectStore::delete_stream tries to explain what happened (and tries to explain how to port the code) https://github.com/apache/arrow-rs-object-store/blob/44e258cd592d6007a69315fd334beb396140a4f2/src/lib.rs#L955-L960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
