zanmato1984 commented on code in PR #48459:
URL: https://github.com/apache/arrow/pull/48459#discussion_r2661182902
##########
cpp/src/arrow/type_traits.h:
##########
@@ -1837,4 +1838,23 @@ constexpr bool is_union(const DataType& type) { return
is_union(type.id()); }
/// @}
+/// \addtogroup c-type-concepts
Review Comment:
How about a nice cup of concepts?
##########
cpp/src/arrow/compute/kernels/hash_aggregate.cc:
##########
@@ -276,46 +276,34 @@ struct AntiExtrema {
static constexpr CType anti_max() { return
std::numeric_limits<CType>::min(); }
};
-template <>
-struct AntiExtrema<bool> {
- static constexpr bool anti_min() { return true; }
- static constexpr bool anti_max() { return false; }
+template <CBooleanConcept CType>
Review Comment:
Simplified with C++20 concepts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
