zanmato1984 commented on code in PR #48459:
URL: https://github.com/apache/arrow/pull/48459#discussion_r2661188479
##########
cpp/src/arrow/compute/kernels/hash_aggregate.cc:
##########
@@ -276,46 +276,34 @@ struct AntiExtrema {
static constexpr CType anti_max() { return
std::numeric_limits<CType>::min(); }
};
-template <>
-struct AntiExtrema<bool> {
- static constexpr bool anti_min() { return true; }
- static constexpr bool anti_max() { return false; }
+template <CBooleanConcept CType>
Review Comment:
Hi @pitrou , do you mind we take this as a starting point of migrating
legacy code to C++20 style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
