pitrou commented on code in PR #48459:
URL: https://github.com/apache/arrow/pull/48459#discussion_r2665062982
##########
cpp/src/arrow/compute/kernels/hash_aggregate.cc:
##########
@@ -270,52 +271,54 @@ struct GroupedCountImpl : public GroupedAggregator {
// ----------------------------------------------------------------------
// MinMax implementation
+// XXX: Consider making these concepts complete and moving to public header.
+
+template <typename T>
+concept CBooleanConcept = std::is_same_v<T, bool>;
Review Comment:
Use `std::same_as`?
##########
cpp/src/arrow/compute/kernels/hash_aggregate.cc:
##########
@@ -270,52 +271,54 @@ struct GroupedCountImpl : public GroupedAggregator {
// ----------------------------------------------------------------------
// MinMax implementation
+// XXX: Consider making these concepts complete and moving to public header.
+
+template <typename T>
+concept CBooleanConcept = std::is_same_v<T, bool>;
+
+// XXX: Ideally we want to have std::floating_point<Float16> = true.
+template <typename T>
+concept CFloatingPointConcept =
+ std::floating_point<T> || std::is_same_v<T, util::Float16>;
+
+template <typename T>
+concept CDecimalConcept = std::is_same_v<T, Decimal32> || std::is_same_v<T,
Decimal64> ||
Review Comment:
By the way, it seems `CTypeTraits<Decimal32>` et al. aren't defined, perhaps
open a separate issue for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
