alinaliBQ commented on code in PR #48595:
URL: https://github.com/apache/arrow/pull/48595#discussion_r2636487146
##########
.github/workflows/cpp_extra.yml:
##########
@@ -339,14 +339,16 @@ jobs:
contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra') ||
contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra: C++')
timeout-minutes: 240
+ permissions:
+ packages: write
env:
ARROW_BUILD_SHARED: ON
ARROW_BUILD_STATIC: OFF
ARROW_BUILD_TESTS: ON
ARROW_BUILD_TYPE: release
ARROW_DEPENDENCY_SOURCE: VCPKG
ARROW_FLIGHT_SQL_ODBC: ON
- ARROW_SIMD_LEVEL: AVX2
Review Comment:
`ARROW_SIMD_LEVEL` is not required for building ODBC and can be omitted
##########
.github/workflows/cpp_extra.yml:
##########
@@ -368,10 +370,6 @@ jobs:
- name: Download Timezone Database
shell: bash
run: ci/scripts/download_tz_database.sh
- - name: Install cmake
- shell: bash
- run: |
- ci/scripts/install_cmake.sh 4.1.2 /usr
- name: Install ccache
Review Comment:
Cmake 4.1.2 is not required for Arrow ODBC, removing this custom cmake
install resolved the issue as the built-in cmake works with the vcpkg nuget
package upload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
