alinaliBQ commented on code in PR #48595:
URL: https://github.com/apache/arrow/pull/48595#discussion_r2678032183
##########
.github/workflows/cpp_extra.yml:
##########
@@ -337,19 +337,22 @@ jobs:
if: >-
needs.check-labels.outputs.force == 'true' ||
contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra') ||
- contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra: C++')
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra: C++') ||
+ contains(join(github.event.pull_request.changed_files, ' '),
'cpp/src/arrow/flight/sql/odbc/')
Review Comment:
@kou I have added a section to add ` CI: Extra` in `labeler.yml`. However it
is not adding new labels.
From my testing in my fork repo, I found that the GitHub Actions only picks
up on the `labeler.yml` from the target branch, and not from the head branch.
From testing at forked repo, I found even when I comment out contents from
`labeler.yml` (in head branch), new labels are still being added.
##########
.github/workflows/cpp_extra.yml:
##########
@@ -337,19 +337,22 @@ jobs:
if: >-
needs.check-labels.outputs.force == 'true' ||
contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra') ||
- contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra: C++')
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra: C++') ||
+ contains(join(github.event.pull_request.changed_files, ' '),
'cpp/src/arrow/flight/sql/odbc/')
Review Comment:
@kou I have added a section to add ` CI: Extra` in `labeler.yml`. However it
is not adding new labels.
From my testing in my fork repo, I found that the GitHub Actions only picks
up on the `labeler.yml` from the target branch, and not from the head branch. I
found even when I comment out contents from `labeler.yml` (in head branch), new
labels are still being added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
