scovich commented on PR #9021: URL: https://github.com/apache/arrow-rs/pull/9021#issuecomment-3721034751
> @scovich thanks for the ping -- I just triggered the tests to run > > What do you think of this PR? Is it ready for another review in your opinion? Two main thoughts: 1. This approach is nice (quite possibly worth merging as-is), but also tantalizingly points to an even more powerful approach. It wasn't immediately clear to me whether that more powerful approach is actually desirable and important enough to puruse; and if it _IS_ desirable, whether this approach is completely aligned with it or would need some tweaking before merge to avoid throwaway work. 2. This is not the first PR to find that extension type detection is a pain to work with (have to either string-match name, which is necessary-but-insufficient, or attempt to instantiate the extension type, which is sufficient but expensive). It would be nice -- not as part of this PR -- to look at ways of improving the increasingly common need to take action when a specific extension type is encountered while cheaply doing the normal behavior otherwise. So mostly I'm hoping for other eyes to avoid my review sending @debugmiller down any bad paths or wasted effort! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
