scovich commented on issue #9113: URL: https://github.com/apache/arrow-rs/issues/9113#issuecomment-3729994195
It's certainly something to think about. I do wonder tho -- what is the use case for manipulating individual variant builders, outside unit tests? Most code should be working with variant arrays and the corresponding builder. In fact, seeing a `VariantBuilder` in arrow code is a likely anti-pattern -- I recently reviewed a PR that used a `VariantBuilder` and then manually built a `Variant` which was manually inserted to a `VariantArrayBuilder`... when `VariantArrayBuilder` implements `VariantBuilderExt` and could have been used directly. That said... we do have a lot of unit tests using `VariantBuilder`, so unit test ergonomics can be a valid argument. I'm just trying to understand who would benefit from this change and why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
