scovich commented on issue #9113: URL: https://github.com/apache/arrow-rs/issues/9113#issuecomment-3731049393
> However, the fact that both I and another user both independently reached for the `VariantBuilder` likely suggests it's a natural solution rather than realizing you can use `VariantArrayBuilder` directly. Back when I first defined `VariantBuilderExt` trait, I wondered if I should have called it `VariantBuilder` and renamed the concrete type to something like `SingleVariantBuilder`... maybe it's time to reconsider that idea? > perhaps... "documentation improvements" to help guide users towards the preferred solution when a more complex usage of the VariantArray is needed with manual conversion of nested types etc.? That sounds _very_ reasonable. Today's `VariantBuilder` is a holdover from the early days of building basic variant support -- before actual arrow arrays came on the scene. I'm guessing it should seldom be needed any more, other than perhaps unit tests? @alamb any reactions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
