alamb commented on code in PR #9137:
URL: https://github.com/apache/arrow-rs/pull/9137#discussion_r2678747639
##########
arrow-buffer/src/builder/boolean.rs:
##########
@@ -526,4 +655,65 @@ mod tests {
assert_eq!(buf.len(), buf2.inner().len());
assert_eq!(buf.as_slice(), buf2.values());
}
+
+ #[test]
+ fn test_extend() {
+ let mut builder = BooleanBufferBuilder::new(0);
+ let bools = vec![true, false, true, true, false, true, true, true,
false];
+ unsafe { builder.extend_trusted_len(bools.clone().into_iter()) };
+ assert_eq!(builder.len(), 9);
+ let finished = builder.finish();
+ for (i, v) in bools.into_iter().enumerate() {
+ assert_eq!(finished.value(i), v);
+ }
+
+ // Test > 64 bits
+ let mut builder = BooleanBufferBuilder::new(0);
+ let bools: Vec<_> = (0..100).map(|i| i % 3 == 0 || i % 7 ==
0).collect();
+ unsafe { builder.extend_trusted_len(bools.clone().into_iter()) };
+ assert_eq!(builder.len(), 100);
+ let finished = builder.finish();
+ for (i, v) in bools.into_iter().enumerate() {
+ assert_eq!(finished.value(i), v, "at index {}", i);
+ }
+ }
+
+ #[test]
+ fn test_extend_misaligned() {
+ // Test misaligned start
+ for offset in 1..65 {
+ let mut builder = BooleanBufferBuilder::new(0);
+ builder.append_n(offset, false);
+
+ let bools: Vec<_> = (0..100).map(|i| i % 3 == 0 || i % 7 ==
0).collect();
+ unsafe { builder.extend_trusted_len(bools.clone().into_iter()) };
+ assert_eq!(builder.len(), offset + 100);
+
+ let finished = builder.finish();
+ for i in 0..offset {
+ assert!(!finished.value(i));
+ }
+ for (i, v) in bools.into_iter().enumerate() {
+ assert_eq!(finished.value(offset + i), v, "at index {}",
offset + i);
+ }
+ }
+ }
+
+ #[test]
+ fn test_extend_misaligned_end() {
+ for len in 1..130 {
+ let mut builder = BooleanBufferBuilder::new(0);
+ let mut bools: Vec<_> = (0..len).map(|i| i % 2 == 0).collect();
+ unsafe { builder.extend_trusted_len(bools.clone().into_iter()) };
+ unsafe { builder.extend_trusted_len(bools.clone().into_iter()) };
+ let copy = bools.clone();
+ bools.extend(copy);
+ assert_eq!(builder.len(), 2 * len);
+
+ let finished = builder.finish();
+ for (i, &v) in bools.iter().enumerate() {
+ assert_eq!(finished.value(i), v, "at index {} for len {}", i,
len);
+ }
+ }
+ }
Review Comment:
Update -- I actually verified you have basically already done this
```shell
cargo llvm-cov --html test -p arrow-buffer
```
<img width="1011" height="699" alt="Image"
src="https://github.com/user-attachments/assets/e99b7b89-3f9b-40cf-a38e-7e9cb553ecb4";
/>
So my analyss is that the testing is good
##########
arrow-buffer/src/builder/boolean.rs:
##########
@@ -526,4 +655,65 @@ mod tests {
assert_eq!(buf.len(), buf2.inner().len());
assert_eq!(buf.as_slice(), buf2.values());
}
+
+ #[test]
+ fn test_extend() {
+ let mut builder = BooleanBufferBuilder::new(0);
+ let bools = vec![true, false, true, true, false, true, true, true,
false];
+ unsafe { builder.extend_trusted_len(bools.clone().into_iter()) };
+ assert_eq!(builder.len(), 9);
+ let finished = builder.finish();
+ for (i, v) in bools.into_iter().enumerate() {
+ assert_eq!(finished.value(i), v);
+ }
+
+ // Test > 64 bits
+ let mut builder = BooleanBufferBuilder::new(0);
+ let bools: Vec<_> = (0..100).map(|i| i % 3 == 0 || i % 7 ==
0).collect();
+ unsafe { builder.extend_trusted_len(bools.clone().into_iter()) };
+ assert_eq!(builder.len(), 100);
+ let finished = builder.finish();
+ for (i, v) in bools.into_iter().enumerate() {
+ assert_eq!(finished.value(i), v, "at index {}", i);
+ }
+ }
+
+ #[test]
+ fn test_extend_misaligned() {
+ // Test misaligned start
+ for offset in 1..65 {
+ let mut builder = BooleanBufferBuilder::new(0);
+ builder.append_n(offset, false);
+
+ let bools: Vec<_> = (0..100).map(|i| i % 3 == 0 || i % 7 ==
0).collect();
+ unsafe { builder.extend_trusted_len(bools.clone().into_iter()) };
+ assert_eq!(builder.len(), offset + 100);
+
+ let finished = builder.finish();
+ for i in 0..offset {
+ assert!(!finished.value(i));
+ }
+ for (i, v) in bools.into_iter().enumerate() {
+ assert_eq!(finished.value(offset + i), v, "at index {}",
offset + i);
+ }
+ }
+ }
+
+ #[test]
+ fn test_extend_misaligned_end() {
+ for len in 1..130 {
+ let mut builder = BooleanBufferBuilder::new(0);
+ let mut bools: Vec<_> = (0..len).map(|i| i % 2 == 0).collect();
+ unsafe { builder.extend_trusted_len(bools.clone().into_iter()) };
+ unsafe { builder.extend_trusted_len(bools.clone().into_iter()) };
+ let copy = bools.clone();
+ bools.extend(copy);
+ assert_eq!(builder.len(), 2 * len);
+
+ let finished = builder.finish();
+ for (i, &v) in bools.iter().enumerate() {
+ assert_eq!(finished.value(i), v, "at index {} for len {}", i,
len);
+ }
+ }
+ }
Review Comment:
Update -- I actually verified you have basically already done this
```shell
cargo llvm-cov --html test -p arrow-buffer
```
<img width="1011" height="699" alt="Image"
src="https://github.com/user-attachments/assets/e99b7b89-3f9b-40cf-a38e-7e9cb553ecb4";
/>
So my analysis is that the testing is good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
