Dandandan commented on PR #9137: URL: https://github.com/apache/arrow-rs/pull/9137#issuecomment-3734529496
> I know I am harping on it a lot, but I can't help shake the feeling that this is so similar to [set_bits](https://github.com/apache/arrow-rs/blob/28cf02db5500d9aa1a8effecc9622b331a5a69fe/arrow-buffer/src/util/bit_mask.rs#L28). That takes an existing set of bits, I realize, but the core use case is to extend an existing mutable buffer I see your point but I think I don't see it being possible to unify them ("copy bits from bitmap to another", vs "write a iterator of bools"). I guess the "copy bits" should be faster than iterator-based for large buffers. ``` /// This will sets all bits on `write_data` in the range `[offset_write..offset_write+len]` /// to be equal to the bits in `data` in the range `[offset_read..offset_read+len]` /// returns the number of `0` bits `data[offset_read..offset_read+len]` /// `offset_write`, `offset_read`, and `len` are in terms of bits ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
