hhhizzz commented on code in PR #9118:
URL: https://github.com/apache/arrow-rs/pull/9118#discussion_r2689548798
##########
parquet/src/arrow/push_decoder/reader_builder/mod.rs:
##########
@@ -603,7 +611,8 @@ impl RowGroupReaderBuilder {
.build_array_reader(self.fields.as_deref(),
&self.projection)
}?;
- let reader = ParquetRecordBatchReader::new(array_reader, plan);
+ let reader =
+ ParquetRecordBatchReader::new(array_reader, plan,
page_offsets.cloned());
Review Comment:
`cloned` may cause extra expense here, can we use `Arc<[PageLocation]>` to
avoid that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
