hhhizzz commented on PR #9118: URL: https://github.com/apache/arrow-rs/pull/9118#issuecomment-3752369923
> > Here's the exists test: > > https://github.com/apache/arrow-rs/blob/13d497af2be5d91c1c57775b8a57487ca05babe3/parquet/src/arrow/async_reader/mod.rs#L1218 > > > > I think we can just add one more UT to test the skipping page with `RowSelectionPolicy` set to `Mask` instead of `Auto` > > Shouldn't these test resolve to `Mask` by default? Can't assert it in the tests right now, because the `ReaderBuilder` is not exposed there. This test doesn’t cover the `Mask` strategy directly. Its purpose is to verify that `Mask` can fall back to `Selector` when page skipping is involved and the policy is `Auto`. Since the fallback has been removed, we need additional tests. I added more in this PR: [https://github.com/sdf-jkl/arrow-rs/pull/1](https://github.com/sdf-jkl/arrow-rs/pull/1) — feel free to review and merge any parts you want to keep. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
