ahsanabbas123 commented on code in PR #48792:
URL: https://github.com/apache/arrow/pull/48792#discussion_r2691316634
##########
cpp/src/arrow/engine/substrait/expression_internal.cc:
##########
@@ -1249,42 +1249,52 @@ Result<std::unique_ptr<substrait::Expression>>
MakeListElementReference(
Result<std::unique_ptr<substrait::Expression::ScalarFunction>>
EncodeSubstraitCall(
const SubstraitCall& call, ExtensionSet* ext_set,
const ConversionOptions& conversion_options) {
+
+ auto scalar_fn =
+ std::make_unique<substrait::Expression::ScalarFunction>();
+
+ // Encode function ONCE per scalar function (FIX)
Review Comment:
@mohit7705 Can you put up the python script which you used to verify this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
