mohit7705 commented on code in PR #48792:
URL: https://github.com/apache/arrow/pull/48792#discussion_r2694511432
##########
cpp/src/arrow/engine/substrait/expression_internal.cc:
##########
@@ -1249,42 +1249,52 @@ Result<std::unique_ptr<substrait::Expression>>
MakeListElementReference(
Result<std::unique_ptr<substrait::Expression::ScalarFunction>>
EncodeSubstraitCall(
const SubstraitCall& call, ExtensionSet* ext_set,
const ConversionOptions& conversion_options) {
+
+ auto scalar_fn =
+ std::make_unique<substrait::Expression::ScalarFunction>();
+
+ // Encode function ONCE per scalar function (FIX)
Review Comment:
@ahsanabbas123 I didn’t use a separate Python script locally. I verified
the fix by rebuilding Arrow C++ (cmake .. + make -j$(nproc)) and reviewing the
serialized Substrait output to ensure function URIs are no longer registered
repeatedly for nested scalar expressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
