daniel-adam-tfs commented on code in PR #596:
URL: https://github.com/apache/arrow-go/pull/596#discussion_r2694160833
##########
parquet/file/file_reader_test.go:
##########
@@ -207,7 +207,7 @@ func (p *PageSerdeSuite) TestDataPageV2() {
p.dataPageHdrV2.Statistics = getDummyStats(statsSize, true)
p.dataPageHdrV2.NumValues = nrows
- p.WriteDataPageHeaderV2(1024, 20, 10)
+ p.WriteDataPageHeaderV2(1024, 0, 0)
Review Comment:
The original version of serializedPageReader.Next() ignored error checking
of `io.ReadFull`. Was that deliberate? I've added the error checking and now
the `p.pageReader.Next()` returns false if the compressed and uncompressed
values are not 0, so I modified those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
