daniel-adam-tfs commented on PR #596:
URL: https://github.com/apache/arrow-go/pull/596#issuecomment-3755476249

   > > I'm also thinking about maybe creating a test docker container to test 
PyArrow <-> arrow-go compatibility. Or are there some other integration tests 
done in some other way that I missed?
   > 
   > Currently the integration tests are simply confirming that arrow-go can 
read the known files with encryption from the github.com/apache/parquet-testing 
repo and then confirm round trip by writing and then reading the locally 
written versions of the files. It doesn't do any cross-language testing. The 
assumption being that if we confirm proper reading of the known good files and 
then confirm we can write and read new versions of the same files, that it 
would be sufficient if _all_ the implementations do the same.
   > 
   > It might be worthwhile to have more explicit cross-implementation testing 
of the encryption files though.
   
   I've modified the tests, so extended the round-trip files. But I'm thinking 
that a cross-implementation verification would still be useful. Using python 
seems like the easiest option, but I'm not sure how to deal with the KMS API 
that is used in PyArrow. You figured out how to make it work with arrow-go, but 
is that API guaranteed to be stable? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to