tustvold commented on code in PR #585: URL: https://github.com/apache/arrow-rs-object-store/pull/585#discussion_r2701019794
########## src/lib.rs: ########## @@ -515,15 +515,43 @@ //! [Apache Iceberg]: https://iceberg.apache.org/ //! [Delta Lake]: https://delta.io/ //! +//! # Cryptography +//! +//! When using the non `*-no-crypto` features, i.e. `aws`, `gcp`, `azure`, etc... this crate makes use +//! of [`aws-lc-rs`] for cryptography. +//! +//! Alternatively if you wish to use [`ring`], e.g. to support WASM targets, you should instead use the +//! `*-no-crypto` feature flags, e.g. `aws-no-crypto`, and then enable the `ring` feature. +//! +//! Note: for TLS to work you will additionally need to register ring as the default rustls cryptography Review Comment: ```suggestion //! Note: for TLS to work you will may need to register ring as the default rustls cryptography ``` As whether you need this depends on what HTTPConnector you are using. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
