tustvold commented on code in PR #585: URL: https://github.com/apache/arrow-rs-object-store/pull/585#discussion_r2701020989
########## Cargo.toml: ########## @@ -71,13 +72,26 @@ wasm-bindgen-futures = "0.4.18" [features] default = ["fs"] -cloud = ["serde", "serde_json", "quick-xml", "hyper", "reqwest", "reqwest/stream", "chrono/serde", "base64", "rand", "ring", "http-body-util", "form_urlencoded", "serde_urlencoded"] -azure = ["cloud", "httparse"] +cloud-no-crypto = ["serde", "serde_json", "quick-xml", "hyper", "reqwest", "reqwest/stream", "chrono/serde", "base64", "rand","http-body-util", "form_urlencoded", "serde_urlencoded"] +cloud = ["aws-lc-rs", "cloud-no-crypto"] + +aws-lc-rs = ["dep:aws-lc-rs", "reqwest/rustls", "rustls-pki-types"] +ring = ["dep:ring", "rustls-pki-types"] + +azure-no-crypto = ["cloud-no-crypto", "httparse"] +azure = ["cloud", "azure-no-crypto"] + fs = ["walkdir"] -gcp = ["cloud", "rustls-pki-types"] -aws = ["cloud", "md-5"] -http = ["cloud"] -tls-webpki-roots = ["reqwest?/rustls-tls-webpki-roots"] Review Comment: Given this change is now spicy enough that I don't think it should go in a non-breaking release, I opted to take the opportunity to remove this feature flag. People can register the certificates manually if they wish to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
