rluvaton commented on code in PR #8951:
URL: https://github.com/apache/arrow-rs/pull/8951#discussion_r2702401478
##########
arrow-buffer/src/builder/null.rs:
##########
@@ -412,4 +439,47 @@ mod tests {
assert_eq!(builder.finish(), None);
}
+
+ #[test]
+ fn test_extend() {
Review Comment:
Please add another test that you extend all valids (the case where
materialization is not really needed)
and another test when you extends all nulls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
