rluvaton commented on code in PR #8951: URL: https://github.com/apache/arrow-rs/pull/8951#discussion_r2702404229
########## arrow-select/src/filter.rs: ########## @@ -37,9 +37,9 @@ use arrow_schema::*; /// [`SlicesIterator`] to copy ranges of values. Otherwise iterate /// over individual rows using [`IndexIterator`] /// -/// Threshold of 0.8 chosen based on <https://dl.acm.org/doi/abs/10.1145/3465998.3466009> +/// Threshold of 0.9 chosen based on benchmarking results /// -const FILTER_SLICES_SELECTIVITY_THRESHOLD: f64 = 0.8; +const FILTER_SLICES_SELECTIVITY_THRESHOLD: f64 = 0.9; Review Comment: Did you run with the same machines as the paper run with? (Intel Xeon Platinum 8124M CPU @3.00GHz with AVX512.) because you might improve on machine a but harm machine b. and if the machine you are running on is not bare metal, you will also have larger noise -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
