jhorstmann commented on code in PR #9217:
URL: https://github.com/apache/arrow-rs/pull/9217#discussion_r2702685411
##########
parquet/src/arrow/array_reader/struct_array.rs:
##########
@@ -158,8 +158,9 @@ impl ArrayReader for StructArrayReader {
}
}
None => {
- for def_level in def_levels {
- bitmap_builder.append(*def_level >=
self.struct_def_level)
+ // Safety: slice iterator has a trusted length
Review Comment:
My benchmark did not actually cover this code, since it reads the leaf
column as a primitive array. That would mean the performance might be even
worse than measured, but also the improvement would be a bit bigger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
