jhorstmann commented on code in PR #9217:
URL: https://github.com/apache/arrow-rs/pull/9217#discussion_r2703842228
##########
parquet/src/arrow/record_reader/definition_levels.rs:
##########
@@ -160,9 +160,10 @@ impl DefinitionLevelDecoder for
DefinitionLevelBufferDecoder {
let start = levels.len();
let (values_read, levels_read) =
decoder.read_def_levels(levels, num_levels)?;
- nulls.reserve(levels_read);
- for i in &levels[start..] {
- nulls.append(i == max_level);
+ // Safety: slice iterator has a trusted length
+ unsafe {
Review Comment:
That would be interesting to try out. It probably will only be faster when
using explicit simd intrinsics to compute that bitmap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
