MugundanMCW commented on code in PR #48539: URL: https://github.com/apache/arrow/pull/48539#discussion_r2703320101
########## ci/scripts/python_wheel_windows_build.bat: ########## @@ -46,67 +65,119 @@ set ARROW_ORC=ON set ARROW_PARQUET=ON set PARQUET_REQUIRE_ENCRYPTION=ON set ARROW_MIMALLOC=ON -set ARROW_SUBSTRAIT=ON set ARROW_S3=ON -set ARROW_TENSORFLOW=ON -set ARROW_WITH_BROTLI=ON -set ARROW_WITH_BZ2=ON -set ARROW_WITH_LZ4=ON -set ARROW_WITH_SNAPPY=ON -set ARROW_WITH_ZLIB=ON -set ARROW_WITH_ZSTD=ON -set CMAKE_INTERPROCEDURAL_OPTIMIZATION=ON -set CMAKE_UNITY_BUILD=ON set CMAKE_GENERATOR=Visual Studio 17 2022 -set CMAKE_PLATFORM=x64 set VCPKG_ROOT=C:\vcpkg set VCPKG_FEATURE_FLAGS=-manifests -set VCPKG_TARGET_TRIPLET=amd64-windows-static-md-%CMAKE_BUILD_TYPE% + +if "%arch%"=="ARM64" ( + set ARROW_SUBSTRAIT=OFF + set ARROW_TENSORFLOW=OFF +) else ( + set ARROW_SUBSTRAIT=ON + set ARROW_TENSORFLOW=ON + set ARROW_WITH_BROTLI=ON + set ARROW_WITH_BZ2=ON + set ARROW_WITH_LZ4=ON + set ARROW_WITH_SNAPPY=ON + set ARROW_WITH_ZLIB=ON + set ARROW_WITH_ZSTD=ON + set CMAKE_INTERPROCEDURAL_OPTIMIZATION=ON + set CMAKE_UNITY_BUILD=ON +) mkdir C:\arrow-build pushd C:\arrow-build -cmake ^ - -DARROW_ACERO=%ARROW_ACERO% ^ - -DARROW_BUILD_SHARED=ON ^ - -DARROW_BUILD_STATIC=OFF ^ - -DARROW_BUILD_TESTS=OFF ^ - -DARROW_COMPUTE=ON ^ - -DARROW_CSV=ON ^ - -DARROW_CXXFLAGS="/MP" ^ - -DARROW_DATASET=%ARROW_DATASET% ^ - -DARROW_DEPENDENCY_SOURCE=VCPKG ^ - -DARROW_DEPENDENCY_USE_SHARED=OFF ^ - -DARROW_FILESYSTEM=ON ^ - -DARROW_FLIGHT=%ARROW_FLIGHT% ^ - -DARROW_GANDIVA=%ARROW_GANDIVA% ^ - -DARROW_GCS=%ARROW_GCS% ^ - -DARROW_HDFS=%ARROW_HDFS% ^ - -DARROW_JSON=ON ^ - -DARROW_MIMALLOC=%ARROW_MIMALLOC% ^ - -DARROW_ORC=%ARROW_ORC% ^ - -DARROW_PACKAGE_KIND="python-wheel-windows" ^ - -DARROW_PARQUET=%ARROW_PARQUET% ^ - -DARROW_S3=%ARROW_S3% ^ - -DARROW_SUBSTRAIT=%ARROW_SUBSTRAIT% ^ - -DARROW_TENSORFLOW=%ARROW_TENSORFLOW% ^ - -DARROW_WITH_BROTLI=%ARROW_WITH_BROTLI% ^ - -DARROW_WITH_BZ2=%ARROW_WITH_BZ2% ^ - -DARROW_WITH_LZ4=%ARROW_WITH_LZ4% ^ - -DARROW_WITH_SNAPPY=%ARROW_WITH_SNAPPY% ^ - -DARROW_WITH_ZLIB=%ARROW_WITH_ZLIB% ^ - -DARROW_WITH_ZSTD=%ARROW_WITH_ZSTD% ^ - -DCMAKE_BUILD_TYPE=%CMAKE_BUILD_TYPE% ^ - -DCMAKE_INSTALL_PREFIX=C:\arrow-dist ^ - -DCMAKE_INTERPROCEDURAL_OPTIMIZATION=%CMAKE_INTERPROCEDURAL_OPTIMIZATION% ^ - -DCMAKE_UNITY_BUILD=%CMAKE_UNITY_BUILD% ^ - -DMSVC_LINK_VERBOSE=ON ^ - -DPARQUET_REQUIRE_ENCRYPTION=%PARQUET_REQUIRE_ENCRYPTION% ^ - -DVCPKG_MANIFEST_MODE=OFF ^ - -DVCPKG_TARGET_TRIPLET=%VCPKG_TARGET_TRIPLET% ^ - -Dxsimd_SOURCE=BUNDLED ^ - -G "%CMAKE_GENERATOR%" ^ - -A "%CMAKE_PLATFORM%" ^ - C:\arrow\cpp || exit /B 1 + +if "%arch%"=="ARM64" ( Review Comment: @pitrou I’ve updated the source to share common code paths between x64 and ARM64. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
