MugundanMCW commented on code in PR #48539: URL: https://github.com/apache/arrow/pull/48539#discussion_r2703346368
########## ci/scripts/python_wheel_windows_build.bat: ########## @@ -24,16 +24,35 @@ py -0p %PYTHON_CMD% -m sysconfig || exit /B 1 -call "C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Auxiliary\Build\vcvars64.bat" +@REM Detect architecture if not set +if "%arch%"=="" set arch=x64 + +@REM Set architecture-specific options +if "%arch%"=="ARM64" ( + set CMAKE_PLATFORM=ARM64 + set VCVARS_BAT=C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsarm64.bat + set VCPKG_TARGET_TRIPLET=arm64-windows + set ARROW_SRC=%GITHUB_WORKSPACE%\arrow + set ARROW_DIST=%GITHUB_WORKSPACE%\arrow-dist +) else ( + set VCVARS_BAT=C:\Program Files ^(x86^)\Microsoft Visual Studio\2022\BuildTools\VC\Auxiliary\Build\vcvars64.bat + set VCPKG_TARGET_TRIPLET=amd64-windows-static-md-%CMAKE_BUILD_TYPE% + set ARROW_SRC=C:\arrow + set ARROW_DIST=C:\arrow-dist +) + +call "%VCVARS_BAT%" @echo on -echo "=== (%PYTHON%) Clear output directories and leftovers ===" -del /s /q C:\arrow-build -del /s /q C:\arrow-dist -del /s /q C:\arrow\python\dist -del /s /q C:\arrow\python\build -del /s /q C:\arrow\python\pyarrow\*.so -del /s /q C:\arrow\python\pyarrow\*.so.* +if "%arch%"=="x64" ( Review Comment: Previously, this condition was needed because .so files are not generated on Windows ARM64, so these cleanup steps would fail there. However, I have now made this block common for both ARM64 and x64 since running these commands does not cause any issues on ARM64 either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
