HyukjinKwon commented on code in PR #48722:
URL: https://github.com/apache/arrow/pull/48722#discussion_r2703652461
##########
cpp/src/arrow/io/file_test.cc:
##########
@@ -115,7 +115,25 @@ TEST_F(TestFileOutputStream,
FileNameWideCharConversionRangeException) {
ASSERT_RAISES(Invalid, ReadableFile::Open(file_name));
}
-// TODO add a test with a valid utf-8 filename
+TEST_F(TestFileOutputStream, FileNameValidUtf8) {
Review Comment:
The file name is actually already being tested but the file creation is not.
There is Windows specific code path described in the PR description but it's a
bit verbose. Let me make the PR description shorter 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
