HyukjinKwon commented on code in PR #48722:
URL: https://github.com/apache/arrow/pull/48722#discussion_r2704407606
##########
cpp/src/arrow/io/file_test.cc:
##########
@@ -115,7 +115,25 @@ TEST_F(TestFileOutputStream,
FileNameWideCharConversionRangeException) {
ASSERT_RAISES(Invalid, ReadableFile::Open(file_name));
}
-// TODO add a test with a valid utf-8 filename
+TEST_F(TestFileOutputStream, FileNameValidUtf8) {
Review Comment:
Ah yes correct. The test doesn't necessarily have to scope it into Windows
only. Was too into the original commits intention..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
