alamb commented on code in PR #9141:
URL: https://github.com/apache/arrow-rs/pull/9141#discussion_r2705563456
##########
arrow-array/src/array/boolean_array.rs:
##########
@@ -93,6 +93,28 @@ impl BooleanArray {
Self { values, nulls }
}
+ /// It returns a new array with the same data and a new null buffer.
+ ///
+ /// The resulting null buffer is the union of the existing nulls and the
provided nulls.
Review Comment:
Thank you @keirsalterego
I am not totally sure about this API now that I see it
For the main use case of https://github.com/apache/arrow-rs/issues/6528 was
to add pre-computed nulls -- so also running it through `union` seems to
circumvent the intention
However, the commentary about arbitrarily setting the null mask (without
causing undefined behavior is a good one)
I am not sure how to proceed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
