keirsalterego commented on code in PR #9141:
URL: https://github.com/apache/arrow-rs/pull/9141#discussion_r2705630471
##########
arrow-array/src/array/boolean_array.rs:
##########
@@ -93,6 +93,28 @@ impl BooleanArray {
Self { values, nulls }
}
+ /// It returns a new array with the same data and a new null buffer.
+ ///
+ /// The resulting null buffer is the union of the existing nulls and the
provided nulls.
Review Comment:
how about balancing the safety concern raised by @tustvold providing 2
methods ?
1. with_nulls that would be safe union version and,
2. with_nulls_unchecked which would be without a union, we can document it
as a unsafe or simply add a heavy warning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
