alamb commented on code in PR #9234:
URL: https://github.com/apache/arrow-rs/pull/9234#discussion_r2712946509
##########
arrow-array/src/array/mod.rs:
##########
@@ -78,18 +78,8 @@ pub use list_view_array::*;
use crate::iterator::ArrayIter;
-mod private {
- /// Private marker trait to ensure [`super::Array`] can not be implemented
outside this crate
- pub trait Sealed {}
-
- impl<T: Sealed> Sealed for &T {}
-}
-
/// An array in the [arrow columnar
format](https://arrow.apache.org/docs/format/Columnar.html)
-///
-/// This trait is sealed as it is not intended for custom array types, rather
only
-/// those defined in this crate.
-pub trait Array: std::fmt::Debug + Send + Sync + private::Sealed {
+pub trait Array: std::fmt::Debug + Send + Sync {
Review Comment:
I think the idea was to mark this trait as `unsafe` and then document what
was required for safety -- namely that all the methods must be consistent with
the arrow spec and consistent (logical_null_count can't exceed len, etc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
