scovich commented on PR #9234: URL: https://github.com/apache/arrow-rs/pull/9234#issuecomment-3807438472
> @scovich completely agree, and I think it makes sense that eventually this trait gets sealed. However, some crates are do willing to risk panics in order to benefit from the flexibility of `trait Array`, and this is a good intermediate step while these crates think or even contribute a better way of satisfying their needs. Understood. I was just commenting that the documentation in this PR, explaining why it's marked `unsafe` (strongly discouraged), doesn't give one of the biggest reasons. Maybe we should add that reason. Or maybe there's enough truly `unsafe` code to outweigh the "mere" panic risk of a cast gone bad? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
