andygrove commented on a change in pull request #214:
URL: https://github.com/apache/arrow-datafusion/pull/214#discussion_r622267646



##########
File path: datafusion/src/execution/context.rs
##########
@@ -916,35 +898,6 @@ mod tests {
         Ok(())
     }
 
-    #[tokio::test]
-    async fn create_variable_expr() -> Result<()> {

Review comment:
       I don't think we should remove support for scalar variables in the 
logical plan. This seems unrelated to changing the default SQL dialect. Users 
can use ScalarVariable without using SQL.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to