andygrove commented on a change in pull request #214:
URL: https://github.com/apache/arrow-datafusion/pull/214#discussion_r623097686
##########
File path: datafusion/src/sql/parser.rs
##########
@@ -21,7 +21,7 @@
use sqlparser::{
ast::{ColumnDef, ColumnOptionDef, Statement as SQLStatement,
TableConstraint},
- dialect::{keywords::Keyword, Dialect, GenericDialect},
+ dialect::{keywords::Keyword, Dialect, PostgreSqlDialect},
Review comment:
Thanks for the continued discussion and progress on this. I think the
outcome is good. Just for context, I have built database gateways in the past
that mimic MySQL and Hive protocols and dialects (different projects) and
although I don't work on any projects these days that need either, I am just
trying to keep options open for future users of DataFusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
