sdf-jkl commented on code in PR #9118:
URL: https://github.com/apache/arrow-rs/pull/9118#discussion_r2722348410
##########
parquet/src/arrow/push_decoder/reader_builder/mod.rs:
##########
@@ -588,6 +582,23 @@ impl RowGroupReaderBuilder {
&mut self.buffers,
)?;
+ // before plan is build below
+ // check if plan is bitmask and if it is, put it in a variable
+ let page_offsets = if plan_builder.resolve_selection_strategy()
+ == RowSelectionStrategy::Mask
+ && plan_builder.selection().is_some_and(|selection| {
+ selection.requires_page_aware_mask(
+ &self.projection,
+ self.row_group_offset_index(row_group_idx),
+ )
+ }) {
+ self.row_group_offset_index(row_group_idx)
+ .and_then(|columns| columns.first())
Review Comment:
I think even this should not work, because we actually need to keep page
offsets for all projected columns and use it in `ReadPlanBuilder`(once we move
it from `ParquetRecordBatchReader`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
