sdf-jkl commented on code in PR #9118:
URL: https://github.com/apache/arrow-rs/pull/9118#discussion_r2718502977
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -1375,8 +1377,11 @@ impl ParquetRecordBatchReader {
RowSelectionCursor::Mask(mask_cursor) => {
// Stream the record batch reader using contiguous segments of
the selection
// mask, avoiding the need to materialize intermediate
`RowSelector` ranges.
+ let page_locations = self.page_offsets.as_deref();
+
while !mask_cursor.is_empty() {
- let Some(mask_chunk) =
mask_cursor.next_mask_chunk(batch_size) else {
+ let Some(mask_chunk) =
mask_cursor.next_mask_chunk(batch_size, page_locations)
Review Comment:
The reader only thinks it's the end of the file when no further rows remain
in `mask_cursor`. Empty page is handled by initial skip in `next_mask_chunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
