Taepper commented on code in PR #46926:
URL: https://github.com/apache/arrow/pull/46926#discussion_r2723868973
##########
c_glib/arrow-glib/compute.h:
##########
@@ -509,6 +509,28 @@ typedef enum /*<prefix=GARROW_NULL_PLACEMENT_>*/ {
GARROW_NULL_PLACEMENT_AT_END,
} GArrowNullPlacement;
+/**
+ * GArrowOptionalNullPlacement:
+ * @GARROW_OPTIONAL_NULL_PLACEMENT_AT_START:
+ * Place nulls and NaNs before any non-null values.
+ * NaNs will come after nulls.
+ * @GARROW_OPTIONAL_NULL_PLACEMENT_AT_END:
+ * Place nulls and NaNs after any non-null values.
+ * NaNs will come before nulls.
+ * @GARROW_OPTIONAL_NULL_PLACEMENT_UNSPECIFIED:
+ * Do not specify null placement.
+ * Null placement should instead
+ *
+ * They are corresponding to `std::optional<arrow::compute::NullPlacement>`
values.
+ *
+ * Since: 24.0.0
+ */
+typedef enum /*<prefix=GARROW_OPTIONAL_NULL_PLACEMENT_>*/ {
+ GARROW_OPTIONAL_NULL_PLACEMENT_AT_START,
+ GARROW_OPTIONAL_NULL_PLACEMENT_AT_END,
+ GARROW_OPTIONAL_NULL_PLACEMENT_UNSPECIFIED,
Review Comment:
Good idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
