kou commented on code in PR #46926:
URL: https://github.com/apache/arrow/pull/46926#discussion_r2731809313
##########
ruby/red-arrow/test/test-sort-key.rb:
##########
@@ -35,40 +35,67 @@ class SortKeyTest < Test::Unit::TestCase
sub_test_case("#initialize") do
test("String") do
- assert_equal("+count",
+ assert_equal("+$count",
Arrow::SortKey.new("count").to_s)
end
test("+String") do
- assert_equal("+count",
+ assert_equal("+$count",
Arrow::SortKey.new("+count").to_s)
end
test("-String") do
- assert_equal("-count",
+ assert_equal("-$count",
Arrow::SortKey.new("-count").to_s)
end
test("Symbol") do
- assert_equal("+-count",
+ assert_equal("+$-count",
Arrow::SortKey.new(:"-count").to_s)
end
test("String, Symbol") do
- assert_equal("--count",
+ assert_equal("-$-count",
Arrow::SortKey.new("-count", :desc).to_s)
end
test("String, String") do
- assert_equal("--count",
+ assert_equal("-$-count",
Arrow::SortKey.new("-count", "desc").to_s)
end
test("String, SortOrder") do
- assert_equal("--count",
+ assert_equal("-$-count",
Arrow::SortKey.new("-count",
Arrow::SortOrder::DESCENDING).to_s)
end
+
+ test("^String") do
+ assert_equal("+^count",
+ Arrow::SortKey.new("^count").to_s)
+ end
+
+ test("-^String") do
+ assert_equal("-^count",
+ Arrow::SortKey.new("-^count").to_s)
+ end
+
+ test("+$String") do
+ assert_equal("+$count",
+ Arrow::SortKey.new("+$count").to_s)
+ end
+
+ test("+^^String") do
+ assert_equal("+^^count",
+ Arrow::SortKey.new("^count", Arrow::SortOrder::ASCENDING,
+ Arrow::NullPlacement::AT_START).to_s)
+ end
+
+ test("+$$String") do
+ assert_equal("+$$count",
+ Arrow::SortKey.new("$count", Arrow::SortOrder::ASCENDING,
+ Arrow::NullPlacement::AT_END).to_s)
Review Comment:
```suggestion
Arrow::SortKey.new("$count", :ascending, :at_end).to_s)
```
##########
ruby/red-arrow/test/test-sort-key.rb:
##########
@@ -35,40 +35,67 @@ class SortKeyTest < Test::Unit::TestCase
sub_test_case("#initialize") do
test("String") do
- assert_equal("+count",
+ assert_equal("+$count",
Arrow::SortKey.new("count").to_s)
end
test("+String") do
- assert_equal("+count",
+ assert_equal("+$count",
Arrow::SortKey.new("+count").to_s)
end
test("-String") do
- assert_equal("-count",
+ assert_equal("-$count",
Arrow::SortKey.new("-count").to_s)
end
test("Symbol") do
- assert_equal("+-count",
+ assert_equal("+$-count",
Arrow::SortKey.new(:"-count").to_s)
end
test("String, Symbol") do
- assert_equal("--count",
+ assert_equal("-$-count",
Arrow::SortKey.new("-count", :desc).to_s)
end
test("String, String") do
- assert_equal("--count",
+ assert_equal("-$-count",
Arrow::SortKey.new("-count", "desc").to_s)
end
test("String, SortOrder") do
- assert_equal("--count",
+ assert_equal("-$-count",
Arrow::SortKey.new("-count",
Arrow::SortOrder::DESCENDING).to_s)
end
+
+ test("^String") do
+ assert_equal("+^count",
+ Arrow::SortKey.new("^count").to_s)
+ end
+
+ test("-^String") do
+ assert_equal("-^count",
+ Arrow::SortKey.new("-^count").to_s)
+ end
+
+ test("+$String") do
+ assert_equal("+$count",
+ Arrow::SortKey.new("+$count").to_s)
+ end
+
+ test("+^^String") do
+ assert_equal("+^^count",
+ Arrow::SortKey.new("^count", Arrow::SortOrder::ASCENDING,
+ Arrow::NullPlacement::AT_START).to_s)
Review Comment:
We can use symbol here:
```suggestion
Arrow::SortKey.new("^count", :ascending, :at_start).to_s)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
