kou commented on code in PR #48577:
URL: https://github.com/apache/arrow/pull/48577#discussion_r2724999659
##########
.github/workflows/cpp_extra.yml:
##########
@@ -336,9 +336,75 @@ jobs:
cd cpp/examples/minimal_build
../minimal_build.build/arrow-example
- odbc:
+ odbc-macos:
needs: check-labels
- name: ODBC
+ name: ODBC ${{ matrix.architecture }} macOS ${{ matrix.macos-version }}
+ runs-on: macos-${{ matrix.macos-version }}
+ if: >-
+ needs.check-labels.outputs.force == 'true' ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra') ||
+ contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'),
'CI: Extra: C++')
+ timeout-minutes: 75
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - architecture: AMD64
+ macos-version: "15-intel"
+ - architecture: ARM64
+ macos-version: "14"
+ env:
+ ARROW_BUILD_TESTS: ON
+ ARROW_FLIGHT_SQL_ODBC: ON
+ ARROW_HOME: /tmp/local
+ steps:
+ - name: Checkout Arrow
+ uses: actions/[email protected]
+ with:
+ fetch-depth: 0
+ submodules: recursive
+ - name: Install Dependencies
+ run: |
+ brew bundle --file=cpp/Brewfile
+ - name: Setup ccache
+ run: |
+ ci/scripts/ccache_setup.sh
+ - name: ccache info
+ id: ccache-info
+ run: |
+ echo "cache-dir=$(ccache --get-config cache_dir)" >> $GITHUB_OUTPUT
+ - name: Cache ccache
+ uses: actions/cache@v4
+ with:
+ path: ${{ steps.ccache-info.outputs.cache-dir }}
+ key: cpp-odbc-ccache-macos-${{ matrix.macos-version }}-${{
hashFiles('cpp/**') }}
+ restore-keys: cpp-odbc-ccache-macos-${{ matrix.macos-version }}-
+ - name: Build
+ run: |
+ # Homebrew uses /usr/local as prefix. So packages
+ # installed by Homebrew also use /usr/local/include. We
+ # want to include headers for packages installed by
+ # Homebrew as system headers to ignore warnings in them.
+ # But "-isystem /usr/local/include" isn't used by CMake
+ # because /usr/local/include is marked as the default
+ # include path. So we disable -Werror to avoid build error
+ # by warnings from packages installed by Homebrew.
+ export BUILD_WARNING_LEVEL=PRODUCTION
+ LIBIODBC_DIR="$(brew --cellar libiodbc)/$(brew list --versions
libiodbc | awk '{print $2}')"
+ export ODBC_INCLUDE_DIR=$LIBIODBC_DIR/include
+ export CXXFLAGS="$CXXFLAGS -I$ODBC_INCLUDE_DIR"
Review Comment:
Could you use `ARROW_CMAKE_ARGS` in caller instead of adding
`-DODBC_INCLUDE_DIR="${ODBC_INCLUDE_DIR:-}"` to `cpp_build.sh`?
```suggestion
ODBC_INCLUDE_DIR=$LIBIODBC_DIR/include
export ARROW_CMAKE_ARGS="-DODBC_INCLUDE_DIR=$ODBC_INCLUDE_DIR"
export CXXFLAGS="$CXXFLAGS -I$ODBC_INCLUDE_DIR"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
