scovich commented on code in PR #9271:
URL: https://github.com/apache/arrow-rs/pull/9271#discussion_r2729382258
##########
arrow-json/src/reader/map_array.rs:
##########
@@ -56,20 +53,8 @@ impl MapArrayDecoder {
_ => unreachable!(),
};
- let keys = make_decoder(
- fields[0].data_type().clone(),
- coerce_primitive,
- strict_mode,
- fields[0].is_nullable(),
- struct_mode,
- )?;
- let values = make_decoder(
- fields[1].data_type().clone(),
- coerce_primitive,
- strict_mode,
- fields[1].is_nullable(),
- struct_mode,
- )?;
+ let keys = ctx.make_decoder(fields[0].data_type().clone(),
fields[0].is_nullable())?;
Review Comment:
Not directly related to this PR: @alamb -- Do we need to OR in our own
`is_nullable` flag here?
Doesn't the same null masking argument apply here as to struct_array.rs? If
not, why not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
