alamb commented on code in PR #9271:
URL: https://github.com/apache/arrow-rs/pull/9271#discussion_r2729416181
##########
arrow-json/src/reader/list_array.rs:
##########
@@ -34,24 +33,16 @@ pub struct ListArrayDecoder<O> {
impl<O: OffsetSizeTrait> ListArrayDecoder<O> {
Review Comment:
I verified this is not a (crate level) public API and thus this is not a
public API change
##########
arrow-json/src/reader/map_array.rs:
##########
@@ -56,20 +53,8 @@ impl MapArrayDecoder {
_ => unreachable!(),
};
- let keys = make_decoder(
- fields[0].data_type().clone(),
- coerce_primitive,
- strict_mode,
- fields[0].is_nullable(),
- struct_mode,
- )?;
- let values = make_decoder(
- fields[1].data_type().clone(),
- coerce_primitive,
- strict_mode,
- fields[1].is_nullable(),
- struct_mode,
- )?;
+ let keys = ctx.make_decoder(fields[0].data_type().clone(),
fields[0].is_nullable())?;
Review Comment:
A MapArray is a ListArray of StructArrays I believe, per
https://arrow.apache.org/docs/format/Columnar.html#data-types
Map | children, keys sortedness | Variable-size List of Structs
-- | -- | --
So I think that means it should follow the same rules as ListArray
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
