Taepper commented on code in PR #46926:
URL: https://github.com/apache/arrow/pull/46926#discussion_r2765814980
##########
python/pyarrow/_acero.pyx:
##########
@@ -254,18 +261,19 @@ class OrderByNodeOptions(_OrderByNodeOptions):
Parameters
----------
- sort_keys : sequence of (name, order) tuples
+ sort_keys : sequence of (name, order, null_placement="at_end") tuples
Names of field/column keys to sort the input on,
along with the order each field/column is sorted in.
- Accepted values for `order` are "ascending", "descending".
Each field reference can be a string column name or expression.
- null_placement : str, default "at_end"
+ Accepted values for `order` are "ascending", "descending".
+ Accepted values for `null_placement` are "at_start", "at_end".
+ null_placement : str, optional
Where nulls in input should be sorted, only applying to
columns/fields mentioned in `sort_keys`.
- Accepted values are "at_start", "at_end".
+ Accepted values are "at_start", "at_end",
"""
- def __init__(self, sort_keys=(), *, null_placement="at_end"):
+ def __init__(self, sort_keys=(), *, null_placement=None):
Review Comment:
I am not quite sure how Deprecation in the python bindings should work, but
I went with this after looking at some other files:
```
def __init__(self, sort_keys=(), *, null_placement=None):
if null_placement is not None:
warnings.warn(
"Specifying null_placement in OrderByNodeOptions is
deprecated "
"as of 24.0.0. Specify null_placement per sort_key instead."
)
self._set_options(sort_keys, null_placement)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
