friendlymatthew commented on code in PR #9283:
URL: https://github.com/apache/arrow-rs/pull/9283#discussion_r2733832506


##########
arrow-row/src/lib.rs:
##########
@@ -501,9 +501,9 @@ enum Codec {
     List(RowConverter),
     /// A row converter for the values array of a run-end encoded array
     RunEndEncoded(RowConverter),
-    /// Row converters for each union field (indexed by type_id)
-    /// and the encoding of null rows for each field
-    Union(Vec<RowConverter>, Vec<OwnedRow>),
+    /// Row converters for each union field (indexed by field position)
+    /// the type_ids for each field position, and the encoding of null rows 
for each field
+    Union(Vec<RowConverter>, Vec<i8>, Vec<OwnedRow>),

Review Comment:
   🤦 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to