Jefffrey commented on code in PR #9283:
URL: https://github.com/apache/arrow-rs/pull/9283#discussion_r2734675854


##########
arrow-row/src/lib.rs:
##########
@@ -1650,10 +1656,16 @@ fn row_lengths(cols: &[ArrayRef], encoders: &[Encoder]) 
-> LengthTracker {
                     .downcast_ref::<UnionArray>()
                     .expect("expected UnionArray");
 
+                let mut type_id_to_field_idx = [0usize; 128];

Review Comment:
   ```suggestion
                   let mut type_id_to_field_idx = [0usize; i8::MAX as usize];
   ```
   
   Just to make the limit more clearly obvious



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to