alamb commented on code in PR #9272:
URL: https://github.com/apache/arrow-rs/pull/9272#discussion_r2738516198
##########
arrow-json/src/lib.rs:
##########
@@ -86,7 +86,7 @@
pub mod reader;
pub mod writer;
-pub use self::reader::{Reader, ReaderBuilder};
+pub use self::reader::{ArrayDecoder, DecoderFactory, Reader, ReaderBuilder,
Tape, TapeElement};
Review Comment:
I agree if we want to allow users to override decoding behavior we are going
to have to given them direct access to Tape / Tape Element - I don't really see
any way around it
> something that stands a good chance of being changed in future - e.g. to
avoid copying strings.
@tustvold -- what strings are you referring to? I don't see any strings
copied here:
https://github.com/apache/arrow-rs/blob/7e5076f1f775a6fd08a4d63389e26e2920fe3f6a/arrow-json/src/reader/tape.rs#L34-L33
https://github.com/apache/arrow-rs/blob/7e5076f1f775a6fd08a4d63389e26e2920fe3f6a/arrow-json/src/reader/tape.rs#L96-L101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
