Dandandan commented on code in PR #9303:
URL: https://github.com/apache/arrow-rs/pull/9303#discussion_r2746776675
##########
parquet/src/file/page_index/column_index.rs:
##########
@@ -191,10 +191,17 @@ impl<T> PrimitiveColumnIndex<T> {
}
})
}
+ /// Returns the null pages.
+ ///
+ /// Values may be `None` when [`ColumnIndex::is_null_page()`] is `true`.
Review Comment:
Oh I should have removed that one (I think the comment was autogenerated).
I thought I could pass the values slice and null_pages slice to the builder
(it is another 30% or so faster) instead of the iterator code, but the
null_pages unfortunately has the valid/invalid reversed compared to "validity".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
