alamb commented on code in PR #9303:
URL: https://github.com/apache/arrow-rs/pull/9303#discussion_r2747027900
##########
parquet/src/file/page_index/column_index.rs:
##########
@@ -191,10 +191,17 @@ impl<T> PrimitiveColumnIndex<T> {
}
})
}
+ /// Returns the null pages.
+ ///
+ /// Values may be `None` when [`ColumnIndex::is_null_page()`] is `true`.
Review Comment:
> but the null_pages unfortunately has the valid/invalid reversed compared
to "validity".
Maybe it is time (another PR) to actually implement something like
`unary_mut` for boolean buffers (so we could invert the bits without a new
allocation)
-
https://github.com/apache/arrow-rs/issues/8809
##########
parquet/src/file/page_index/column_index.rs:
##########
@@ -191,10 +191,17 @@ impl<T> PrimitiveColumnIndex<T> {
}
})
}
+ /// Returns the null pages.
+ ///
+ /// Values may be `None` when [`ColumnIndex::is_null_page()`] is `true`.
Review Comment:
> but the null_pages unfortunately has the valid/invalid reversed compared
to "validity".
Maybe it is time (another PR) to actually implement something like
`unary_mut` for boolean buffers (so we could invert the bits without a new
allocation)
- https://github.com/apache/arrow-rs/issues/8809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
